[galaxy-commits] commit/galaxy-central: jgoecks: Trackster: interpret feature track data using 0-based, half-open coordinate system.

[Bitbucket]

1 new commit in galaxy-central:


https://bitbucket.org/galaxy/galaxy-central/changeset/da1ccd088659/
changeset:   da1ccd088659
user:        jgoecks
date:        2011-12-02 17:10:04
summary:     Trackster: interpret feature track data using 0-based, half-open coordinate system.
affected #:  1 file

diff -r 9eddcedc574e0a071fce78f51b9352d3efb7635c -r da1ccd08865963c99a55b621af481023b61e3b32 static/scripts/trackster.js
--- a/static/scripts/trackster.js
+++ b/static/scripts/trackster.js
@@ -4294,6 +4294,8 @@
 
 /**
  * Abstract object for painting feature tracks. Subclasses must implement draw_element() for painting to work.
+ * Painter uses a 0-based, half-open coordinate system; start coordinate is closed--included--and the end is open.
+ * This coordinate system matches the BED format.
  */
 var FeaturePainter = function(data, view_start, view_end, prefs, mode, alpha_scaler, height_scaler) {
     Painter.call(this, data, view_start, view_end, prefs, mode);
@@ -4419,7 +4421,8 @@
         var 
             feature_uid = feature[0],
             feature_start = feature[1],
-            feature_end = feature[2], 
+            // -1 because end is not included in feature; see FeaturePainter documentation for details.
+            feature_end = feature[2] - 1,
             feature_name = feature[3],
             f_start = Math.floor( Math.max(0, (feature_start - tile_low) * w_scale) ),
             f_end   = Math.ceil( Math.min(width, Math.max(0, (feature_end - tile_low) * w_scale)) ),
@@ -4537,7 +4540,8 @@
                 for (var k = 0, k_len = feature_blocks.length; k < k_len; k++) {
                     var block = feature_blocks[k],
                         block_start = Math.floor( Math.max(0, (block[0] - tile_low) * w_scale) ),
-                        block_end = Math.ceil( Math.min(width, Math.max((block[1] - tile_low) * w_scale)) ),
+                        // -1 because end is not included in feature; see FeaturePainter documentation for details.
+                        block_end = Math.ceil( Math.min(width, Math.max((block[1] - 1 - tile_low) * w_scale)) ),
                         last_block_start, last_block_end;
 
                     // Skip drawing if block not on tile.

Repository URL: https://bitbucket.org/galaxy/galaxy-central/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.